Wrong logging level for ESP_LOGI [IDFGH-5232]

[dkatsig]

Well, it's really minor but I think that ESP_LOGI actually logs with error level

In esp_idf 4.2 (esp_log.h, line 49)

Code: [Select all] [Expand/Collapse]

1. #define ESP_LOGI( tag, format, ... )  if (LOG_LOCAL_LEVEL >= ESP_LOG_INFO)    { esp_log_write(ESP_LOG_INFO,    tag, LOG_FORMAT(E, format), esp_log_timestamp(), tag, ##__VA_ARGS__); }

GeSHi © Codebox Plus Extension

should be

Code: [Select all] [Expand/Collapse]

1. #define ESP_LOGI( tag, format, ... )  if (LOG_LOCAL_LEVEL >= ESP_LOG_INFO)    { esp_log_write(ESP_LOG_INFO,    tag, LOG_FORMAT(I, format), esp_log_timestamp(), tag, ##__VA_ARGS__); }

GeSHi © Codebox Plus Extension

I am in commit c40f2590bf759ff60ef122afa79b4ec04e7633d2 (HEAD -> v4.2, tag: v4.2) of esp_idf

[ESP_Alvin]

Moderator's note: edit the topic title for issue tracking, thanks for reporting.

[ESP_Angus]

Hi dkatsig,

Thanks for noticing this! We run some of our ESP-IDF automated tests on the host system, and to do this we have to stub out some of the lower-level functions like logging, flash, etc.

The stub header for logging in spi_flash host testing does indeed have this typo and logs at the wrong level, we'll fix this.

The header used in the esp-idf log component for on-device firmware logs at the correct level.

Thanks again for pointing this out.